Skip to content

Conversation

@no1wudi
Copy link
Contributor

@no1wudi no1wudi commented Jan 10, 2026

Summary

Fix coding style violations in nuttx-apps to comply with checkpatch.sh requirements. This change addresses various style issues identified by the automated style checker, including case statement formatting, include placement, whitespace issues, long line formatting, and bracket alignment across multiple application modules.

Impact

  • Impact on user: NO - Pure style change, no functional changes
  • Impact on build: NO - No build system changes
  • Impact on hardware: NO - No hardware-related changes
  • Impact on documentation: NO - No documentation changes
  • Impact on security: NO - No security impact
  • Impact on compatibility: NO - No API or behavior changes

Testing

Verified all staged changes pass checkpatch.sh:

git diff --cached | tools/checkpatch.sh -
✔️ All checks pass.

@xiaoxiang781216
Copy link
Contributor

@no1wudi please fix:

Used config files:
    1: .codespellrc
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/elf/tests/pthread/pthread.c:125: exitted ==> exited
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/nxflat/tests/pthread/pthread.c:122: exitted ==> exited
/home/runner/work/nuttx-apps/nuttx-apps/apps/system/telnet/telnet_chatd.c:43: licesne ==> license
/home/runner/work/nuttx-apps/nuttx-apps/apps/system/telnet/telnet_client.c:43: licesne ==> license
Some checks failed. For contributing guidelines, see:
  https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md
Error: Process completed with exit code 1.

Fix various coding style issues including:
- Case statement formatting
- Include placement and ordering
- Whitespace issues
- Long line formatting
- Bracket alignment

Affected modules:
- audioutils, examples, include
- netutils, system

Signed-off-by: Huang Qi <[email protected]>
Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @no1wudi :-)

@xiaoxiang781216 xiaoxiang781216 merged commit 4e8a0ae into apache:master Jan 11, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants