Skip to content

Conversation

@HedongGao
Copy link
Contributor

Summary

Fix a issue of vlan pcp config 3305

Impact

User can config vlan pcp when add it, and default pcp is 0
vconfig add eth0 10 will create eth0.10 with VID=10 and no PCP(0)
vconfig add eth0 10 3 will create eth0.10 with VID=10 and PCP=3

Testing

Open the compilation options CONFIG_NET_VLAN and CONFIG_NSH_DISABLE_VCONFIG.
Add a vlan interface withc comand: vconfig add eth0 10 3; ifconfig eth0.10 192.168.10.2/24, config host vlan interface and ping from sim to host , then check pcp in packet.

Change a pcp and check agin.

Fix a issue of vlan pcp config.
`vconfig add eth0 10` will create eth0.10 with VID=10 and no PCP(0)
`vconfig add eth0 10 3` will create eth0.10 with VID=10 and PCP=3

Signed-off-by: gaohedong <[email protected]>
Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HedongGao :-)

@xiaoxiang781216 xiaoxiang781216 merged commit d594c95 into apache:master Jan 11, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] netlib_add_vlan definition and implementation mismatch

3 participants