Skip to content

boards/arm: add nucleo-c092rc support #16168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025

Conversation

raiden00pl
Copy link
Member

Summary

add nucleo-c092rc support

Impact

new board supported

Testing

tested with included jumbo configuration

@github-actions github-actions bot added Area: Documentation Improvements or additions to documentation Board: arm Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces. labels Apr 9, 2025
Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a commit message and describe the implemented functionality

@nuttxpr
Copy link

nuttxpr commented Apr 9, 2025

[Experimental Bot, please feedback here]

No, this PR description does not adequately meet the NuttX requirements. While it touches on the required sections, it lacks crucial details. Here's a breakdown of what's missing:

  • Summary: While it states "add nucleo-c092rc support," it doesn't explain why this support is necessary (is it a new board? Was there a request? etc.), what functional parts of the code are changed (e.g., board configuration files, drivers, etc.), or how the change works.

  • Impact: Simply stating "new board supported" is insufficient. While it implies a new feature, the PR description needs to address all the other impact points specifically. Even if the answer is "NO", it should be explicitly stated. For example:

    • Impact on user: YES (Users can now use this new board)
    • Impact on build: Possibly YES (if new build options are added) - needs clarification
    • Impact on hardware: YES (specifically the nucleo-c092rc board)
    • Impact on documentation: Likely YES (documentation should be added for the new board) - needs confirmation and details
    • Impact on security: NO (explicitly state, even if no impact)
    • Impact on compatibility: NO (explicitly state, even if no impact)
  • Testing: "Tested with included jumbo configuration" is vague. What does "tested" mean? What were the specific tests performed? What were the results of those tests? The "Testing logs before change" and "Testing logs after change" sections are empty, making it impossible to verify the functionality. The build host details are also missing.

In short, the PR description needs to be much more specific and provide concrete evidence that the changes work as intended.

add nucleo-c092rc board support

Signed-off-by: raiden00pl <[email protected]>
@acassis acassis requested review from lupyuen and hartmannathan April 9, 2025 15:09
add minimal NSH configuration for nucleo-c071rb

Signed-off-by: raiden00pl <[email protected]>
add minimal NSH configuration for nucleo-c092rc

Signed-off-by: raiden00pl <[email protected]>
@xiaoxiang781216 xiaoxiang781216 merged commit 1b9e6a8 into apache:master Apr 10, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Documentation Improvements or additions to documentation Board: arm Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants