[BREAKING] boards/defconfig: remove unused config about dd #16198
Conversation
github-actions
bot
added
Board: arm
Board: openrisc
Board: z80
Size: S
|
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides a summary and points to a related PR for impact, it lacks crucial details. Specifically:
In short, the PR needs to be significantly more detailed to meet the NuttX requirements. |
|
Sorry @cederom : Should we consider this PR a Breaking Change? Because CI Jobs for NuttX Kernel won't succeed, unless we patch NuttX Apps? Thanks :-) |
jerpelea
added
the
breaking change
|
Hi @Donny9: Since this is a Breaking Change, could you please follow the Breaking Change Handling Process, and start the voting on the Mailing List? Thanks :-) (1) Please remember to indicate that voting will be open for 72 hours |
Signed-off-by: Lup Yuen Lee <[email protected]>
|
Hi @Donny9: Because the Normal CI Checks won't work for this Breaking PR, I'm now running the Special CI Checks (see below) on our NuttX Build Farm. The CI Checks will complete in 36 hours, the CI Logs will appear here: https://gist.github.com/nuttxpr https://github.com/lupyuen/nuttx-release/blob/main/run-ci-special.sh ## Repeat forever for All CI Jobs
for (( ; ; )); do
for job in \
arm-01 arm-02 arm-03 arm-04 \
arm-05 arm-06 arm-07 arm-08 \
arm-09 arm-10 arm-11 arm-12 \
arm-13 arm-14 \
arm64-01 \
other \
risc-v-01 risc-v-02 risc-v-03 risc-v-04 \
risc-v-05 risc-v-06 risc-v-07 \
sim-01 sim-02 sim-03 \
x86_64-01 \
xtensa-01 xtensa-02 xtensa-03
do
## Run the CI in Docker Container
## If CI Test Hangs: Kill it after 3 hours
sudo docker run -it \
ghcr.io/apache/nuttx/apache-nuttx-ci-linux:latest \
/bin/bash -c "
set -x ;
uname -a ;
cd ;
pwd ;
git clone https://github.com/Donny9/incubator-nuttx nuttx --branch sem ;
git clone https://github.com/Donny9/incubator-nuttx-apps apps --branch system_dd ;
pushd nuttx ; git reset --hard HEAD ; echo NuttX Source: https://github.com/apache/nuttx/tree/\$(git rev-parse HEAD) ; popd ;
pushd apps ; git reset --hard HEAD ; echo NuttX Apps: https://github.com/apache/nuttx-apps/tree/\$(git rev-parse HEAD) ; popd ;
sleep 10 ;
cd nuttx/tools/ci ;
( sleep 10800 ; echo Killing pytest after timeout... ; pkill -f pytest )&
(./cibuild.sh -c -A -N -R testlist/$job.dat || echo '***** BUILD FAILED') ;
"
done |
|
Hmm this one looks only like removing |
since system dd is enable automatically in no small config:
then, both implementation will unsync, which already happen now, please review apache/nuttx-apps#3057 to find the difference. |
lupyuen
changed the title
|
Sorry @Donny9 I think we need to update Do we need to update all defconfigs containing |
okay~ |
|
Sorry @Donny9: Update: |
github-actions
bot
added
the
Area: Documentation
@lupyuen i don't find any issue about olimex-stm32-p407/knsh's defconfig at my local enviroment, please check again~ |
|
@Donny9 Can you check this error? Thanks! |
There was a problem hiding this comment.
@Donny9: The Special CI Checks for this PR are all successful except for stm32l0538-disco:nsh. Please remember to fix stm32l0538-disco:nsh and we'll rerun the Special CI Checks thanks!
|
@Donny9 feel free to add |
Signed-off-by: dongjiuzhu1 <[email protected]>
Signed-off-by: dongjiuzhu1 <[email protected]>
@raiden00pl I found that the reason for the flash overflow issue is the system dd calling the clock_gettime function. Therefore, I added the CONFIG_SYSTEM_DD_STATS option to enable this function（like origin config NSH_CMDOPT_DD_STATS）, with the default value set to 'y'. Let's disable this configuration to reduce flash memory usage and maintain consistency with the original configuration. |
Done~ |
|
Cool! The Special CI Checks are still running, we'll finish the checks in about 6 hours. |
|
@Donny9 Please close the voting. Thanks!
|
Summary
boards/defconfig: remove unused config about dd
Impact
see apache/nuttx-apps#3057
Testing
sim:nsh