-
Notifications
You must be signed in to change notification settings - Fork 1.3k
arch/xtensa: add crt0 to initialize environment #16208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides a summary and mentions testing, it lacks crucial details. Here's a breakdown of what's missing:
In short, the PR needs more detail and evidence to demonstrate the change's validity and impact. It needs to convince a reviewer that the change is necessary, works correctly, and doesn't introduce unintended consequences. |
8fdaa00
to
a1c934d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the title to
arch/xtensa: add crt0 to initialize environment
and add a commit description which describes the change
we use crt0 inside of start hook in pr apache#16154, so xtensa also need add it. Signed-off-by: anjiahao <[email protected]>
a1c934d
to
b2e39ae
Compare
@jerpelea thanks, i add some description for this change |
Testing on our internal CI... |
Everything is fine with this PR. It solves #16201 . Thanks, @anjiahao1 ! |
Summary
add crt0 to initialize environment for xtensa arch
we use crt0 inside of start hook in pr #16154, so xtensa also need add it.
Impact
fix xtensa elf build
Testing
build esp32-devkitc:elf