-
Notifications
You must be signed in to change notification settings - Fork 1.3k
drivers/leds: Add support for KTD2052 #16217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This commit adds support for the KTD2052 LED driver chip. Signed-off-by: Tyler Bennett <[email protected]>
[Experimental Bot, please feedback here] No, this PR description does not fully meet the NuttX requirements. Here's why and how to fix it:
Example of Improved PR Description:
nsh> ktd2052_test # Example test application
By providing more detail and addressing all the required points, your PR will be much easier to review and merge. |
@stbenn please include a Documentation to https://nuttx.apache.org/docs/latest/components/drivers/character/leds/index.html and an app testing application, this way users could use it without facing issues |
****************************************************************************/ | ||
|
||
/* Set RGB value for a single module */ | ||
#define KTDIOSETRGB _PWMIOC(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use ioctl number from include/nuttx/leds/userled.h
@acassis I can add those, but it may be a little bit until I get around to it. If you would prefer to wait on this PR until those are implemented, that is understandable. |
@stbenn we can merge it, but I think it is better wait for your commit with Documentation and apps example, it avoids we losing track of it. I will move this PR to draft, ok? |
@acassis, sounds good to me 👍 |
This commit adds support for the KTD2052 LED driver chip.
Summary
Driver implementation necessary to interface with KTD2052 LED driver chips.
Originally authored by @ArrestedLightning : https://github.com/ArrestedLightning/nuttx/tree/ktd2052
Impact
Adds Kconfig option to LED driver configuration. Does not change compatibility of existing drivers.
Testing
This driver was tested on a custom KTD2052 driver board.