drivers/video/vnc: Replace direct semcount access with nxsem_get_value #16222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the dedicated nuttx internal interface for debugging semaphore value, instead of accessing it directly. Signed-off-by: Jukka Laitinen <[email protected]>
github-actions
bot
added
Area: Video
Size: S
xiaoxiang781216
approved these changes
Apr 16, 2025
|
[Experimental Bot, please feedback here] No. The PR summary is insufficient. It does not explain why the change is necessary (i.e., what problem does it solve? Why is direct access bad?). The testing section is also inadequate. "Built and executed" is not sufficient testing information. What were the expected results? Did the tests pass both before and after the change, verifying the change did not introduce regressions? Provide actual log output, not just a general statement. The Impact section could also benefit from specifically answering each question with NO/YES, even if the answer is NO, for better clarity and consistency. |
pussuw
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace direct semaphore value access with nxsem_get_value().
This blocks CI for #16194
Impact
No functional impact
Testing
Built and executed sim:vncserver test, which uses this.