refactor: Centralize date/time handling with Timestamp wrapper

bin/oay/Cargo.toml

@@ -45,7 +45,6 @@ axum = { version = "0.8.6" }
 dav-server = { version = "0.8", optional = true }
 dav-server-opendalfs = { version = "0.6.0", path = "../../integrations/dav-server", optional = true }
 futures-util = { version = "0.3.29", optional = true }
-jiff = { version = "0.2.15" }
 log = { version = "0.4.27" }
 logforth = { version = "0.28.1", features = ["starter-log"] }
 opendal = { version = "0.54.0", path = "../../core", features = [

bindings/c/src/metadata.rs

@@ -131,7 +131,7 @@ impl opendal_metadata {
         let mtime = self.deref().last_modified();
         match mtime {
             None => -1,
-            Some(time) => time.as_millisecond(),
+            Some(time) => time.into_inner().as_millisecond(),
         }
     }
 }

bindings/cpp/Cargo.toml

@@ -34,7 +34,6 @@ anyhow = { version = "1.0.100" }
 cxx = { version = "1.0.186" }
 cxx-async = { version = "0.1.3", optional = true }
 futures = { version = "0.3.31" }
-jiff = { version = "0.2.15" }
 # this crate won't be published, we always use the local version
 opendal = { version = ">=0", path = "../../core", features = ["blocking"] }
 tokio = { version = "1.27", features = ["fs", "macros", "rt-multi-thread"] }

bindings/haskell/Cargo.toml

@@ -31,7 +31,6 @@ crate-type = ["cdylib"]
 doc = false
 
 [dependencies]
-jiff = { version = "0.2.15" }
 log = { version = "0.4", features = ["std"] }
 # this crate won't be published, we always use the local version
 opendal = { version = ">=0", path = "../../core", features = [

bindings/java/Cargo.toml

@@ -151,7 +151,6 @@ services-compfs = ["opendal/services-compfs"]
 
 [dependencies]
 anyhow = { version = "1.0.100" }
-jiff = { version = "0.2.15" }
 jni = { version = "0.21.1" }
 # this crate won't be published, we always use the local version
 opendal = { version = ">=0", path = "../../core", features = [

bindings/java/src/convert.rs

@@ -16,7 +16,6 @@
 // under the License.
 
 use crate::Result;
-use jiff::Timestamp;
 use jni::JNIEnv;
 use jni::objects::JObject;
 use jni::objects::JString;
@@ -127,7 +126,7 @@ pub(crate) fn read_instant_field_to_timestamp(
     env: &mut JNIEnv<'_>,
     obj: &JObject,
     field: &str,
-) -> Result<Option<Timestamp>> {
+) -> Result<Option<opendal::raw::Timestamp>> {
     let result = env.get_field(obj, field, "Ljava/time/Instant;")?.l()?;
     if result.is_null() {
         return Ok(None);
@@ -137,14 +136,17 @@ pub(crate) fn read_instant_field_to_timestamp(
         .call_method(&result, "getEpochSecond", "()J", &[])?
         .j()?;
     let nano = env.call_method(&result, "getNano", "()I", &[])?.i()?;
-    Timestamp::new(epoch_second, nano).map(Some).map_err(|err| {
-        Error::new(
-            ErrorKind::Unexpected,
-            format!("invalid timestamp: seconds={epoch_second}, nanos={nano}"),
-        )
-        .set_source(err)
-        .into()
-    })
+
+    opendal::raw::Timestamp::from_second(epoch_second)
+        .map(Some)
+        .map_err(|err| {
+            Error::new(
+                ErrorKind::Unexpected,
+                format!("invalid timestamp: seconds={epoch_second}, nanos={nano}"),
+            )
+            .set_source(err)
+            .into()
+        })
 }
 
 pub(crate) fn offset_length_to_range(offset: i64, length: i64) -> Result<(Bound<u64>, Bound<u64>)> {

bindings/java/src/lib.rs

@@ -156,8 +156,8 @@ fn make_metadata<'a>(env: &mut JNIEnv<'a>, metadata: Metadata) -> Result<JObject
                     "ofEpochSecond",
                     "(JJ)Ljava/time/Instant;",
                     &[
-                        JValue::Long(v.as_second()),
-                        JValue::Long(v.subsec_nanosecond() as jlong),
+                        JValue::Long(v.into_inner().as_second()),
+                        JValue::Long(v.into_inner().subsec_nanosecond() as jlong),
                     ],
                 )?
                 .l()?)

bindings/nodejs/src/options.rs

@@ -16,7 +16,7 @@
 // under the License.
 
 use napi::bindgen_prelude::BigInt;
-use opendal::raw::{BytesRange, parse_datetime_from_rfc3339};
+use opendal::raw::{BytesRange, Timestamp};
 use std::collections::HashMap;
 
 #[napi(object)]
@@ -79,10 +79,10 @@ impl From<StatOptions> for opendal::options::StatOptions {
     fn from(value: StatOptions) -> Self {
         let if_modified_since = value
             .if_modified_since
-            .and_then(|v| parse_datetime_from_rfc3339(&v).ok());
+            .and_then(|v| v.parse::<Timestamp>().ok());
         let if_unmodified_since = value
             .if_unmodified_since
-            .and_then(|v| parse_datetime_from_rfc3339(&v).ok());
+            .and_then(|v| v.parse::<Timestamp>().ok());
 
         Self {
             if_modified_since,
@@ -215,10 +215,10 @@ impl From<ReadOptions> for opendal::options::ReadOptions {
         let range = value.make_range();
         let if_modified_since = value
             .if_modified_since
-            .and_then(|v| parse_datetime_from_rfc3339(&v).ok());
+            .and_then(|v| v.parse::<Timestamp>().ok());
         let if_unmodified_since = value
             .if_unmodified_since
-            .and_then(|v| parse_datetime_from_rfc3339(&v).ok());
+            .and_then(|v| v.parse::<Timestamp>().ok());
 
         Self {
             version: value.version,
@@ -329,10 +329,10 @@ impl From<ReaderOptions> for opendal::options::ReaderOptions {
     fn from(value: ReaderOptions) -> Self {
         let if_modified_since = value
             .if_modified_since
-            .and_then(|v| parse_datetime_from_rfc3339(&v).ok());
+            .and_then(|v| v.parse::<Timestamp>().ok());
         let if_unmodified_since = value
             .if_unmodified_since
-            .and_then(|v| parse_datetime_from_rfc3339(&v).ok());
+            .and_then(|v| v.parse::<Timestamp>().ok());
 
         Self {
             version: value.version,

bindings/ocaml/src/operator/metadata.rs

@@ -62,5 +62,8 @@ pub fn metadata_etag(metadata: &mut Metadata) -> Option<String> {
 #[ocaml::func]
 #[ocaml::sig("metadata -> int64 option ")]
 pub fn metadata_last_modified(metadata: &mut Metadata) -> Option<i64> {
-    metadata.0.last_modified().map(|t| t.as_second())
+    metadata
+        .0
+        .last_modified()
+        .map(|t| t.into_inner().as_second())
 }

bindings/python/src/metadata.rs

@@ -16,7 +16,6 @@
 // under the License.
 
 use crate::*;
-use jiff::Timestamp;
 use std::collections::HashMap;
 
 #[pyclass(module = "opendal")]
@@ -121,8 +120,8 @@ impl Metadata {
 
     /// Last modified time
     #[getter]
-    pub fn last_modified(&self) -> Option<Timestamp> {
-        self.0.last_modified()
+    pub fn last_modified(&self) -> Option<jiff::Timestamp> {
+        self.0.last_modified().map(Into::into)
     }
 
     /// Version of this entry, if available.

bindings/python/src/options.rs

@@ -16,7 +16,6 @@
 // under the License.
 
 use dict_derive::FromPyObject;
-use jiff::Timestamp;
 use opendal::{self as ocore, raw::BytesRange};
 use pyo3::pyclass;
 use std::collections::HashMap;
@@ -33,8 +32,8 @@ pub struct ReadOptions {
     pub size: Option<usize>,
     pub if_match: Option<String>,
     pub if_none_match: Option<String>,
-    pub if_modified_since: Option<Timestamp>,
-    pub if_unmodified_since: Option<Timestamp>,
+    pub if_modified_since: Option<jiff::Timestamp>,
+    pub if_unmodified_since: Option<jiff::Timestamp>,
     pub content_type: Option<String>,
     pub cache_control: Option<String>,
     pub content_disposition: Option<String>,
@@ -72,8 +71,8 @@ impl From<ReadOptions> for ocore::options::ReadOptions {
             version: opts.version,
             if_match: opts.if_match,
             if_none_match: opts.if_none_match,
-            if_modified_since: opts.if_modified_since,
-            if_unmodified_since: opts.if_unmodified_since,
+            if_modified_since: opts.if_modified_since.map(Into::into),
+            if_unmodified_since: opts.if_unmodified_since.map(Into::into),
             concurrent: opts.concurrent.unwrap_or_default(),
             chunk: opts.chunk,
             gap: opts.gap,
@@ -90,8 +89,8 @@ impl From<ReadOptions> for ocore::options::ReaderOptions {
             version: opts.version,
             if_match: opts.if_match,
             if_none_match: opts.if_none_match,
-            if_modified_since: opts.if_modified_since,
-            if_unmodified_since: opts.if_unmodified_since,
+            if_modified_since: opts.if_modified_since.map(Into::into),
+            if_unmodified_since: opts.if_unmodified_since.map(Into::into),
             concurrent: opts.concurrent.unwrap_or_default(),
             chunk: opts.chunk,
             gap: opts.gap,
@@ -146,8 +145,8 @@ pub struct StatOptions {
     pub version: Option<String>,
     pub if_match: Option<String>,
     pub if_none_match: Option<String>,
-    pub if_modified_since: Option<Timestamp>,
-    pub if_unmodified_since: Option<Timestamp>,
+    pub if_modified_since: Option<jiff::Timestamp>,
+    pub if_unmodified_since: Option<jiff::Timestamp>,
     pub content_type: Option<String>,
     pub cache_control: Option<String>,
     pub content_disposition: Option<String>,
@@ -159,8 +158,8 @@ impl From<StatOptions> for ocore::options::StatOptions {
             version: opts.version,
             if_match: opts.if_match,
             if_none_match: opts.if_none_match,
-            if_modified_since: opts.if_modified_since,
-            if_unmodified_since: opts.if_unmodified_since,
+            if_modified_since: opts.if_modified_since.map(Into::into),
+            if_unmodified_since: opts.if_unmodified_since.map(Into::into),
             override_content_type: opts.content_type,
             override_cache_control: opts.cache_control,
             override_content_disposition: opts.content_disposition,

core/src/lib.rs

@@ -19,7 +19,6 @@
     html_logo_url = "https://raw.githubusercontent.com/apache/opendal/main/website/static/img/logo.svg"
 )]
 #![cfg_attr(docsrs, feature(doc_cfg))]
-#![cfg_attr(docsrs, doc(auto_cfg))]
 //! Apache OpenDAL™ is an Open Data Access Layer that enables seamless interaction with diverse storage services.
 //!
 //! OpenDAL's development is guided by its vision of **One Layer, All Storage** and its core principles: **Open Community**, **Solid Foundation**, **Fast Access**, **Object Storage First**, and **Extensible Architecture**. Read the explained vision at [OpenDAL Vision](https://opendal.apache.org/vision).

core/src/raw/adapters/typed_kv/api.rs

@@ -22,8 +22,7 @@ use crate::ErrorKind;
 use crate::Metadata;
 use crate::Result;
 use crate::Scheme;
-use crate::raw::MaybeSend;
-use jiff::Timestamp;
+use crate::raw::{MaybeSend, Timestamp};
 use std::fmt::Debug;
 use std::future::Future;
 use std::future::ready;

core/src/raw/http_util/header.rs

@@ -31,7 +31,6 @@ use http::header::CONTENT_TYPE;
 use http::header::ETAG;
 use http::header::LAST_MODIFIED;
 use http::header::LOCATION;
-use jiff::Timestamp;
 use md5::Digest;
 
 use crate::EntryMode;
@@ -95,7 +94,7 @@ pub fn parse_content_range(headers: &HeaderMap) -> Result<Option<BytesContentRan
 /// Parse last modified from header map.
 pub fn parse_last_modified(headers: &HeaderMap) -> Result<Option<Timestamp>> {
     parse_header_to_str(headers, LAST_MODIFIED)?
-        .map(parse_datetime_from_rfc2822)
+        .map(Timestamp::parse_rfc2822)
         .transpose()
 }