-
Notifications
You must be signed in to change notification settings - Fork 646
chore(bindings/python): Add Justfile and format codebase #6677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this, but the change set is too complex to me.
most of the changes are a result of linting and formatting from ruff. the tests and the benchmarks pass as usual. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this! I’d really like us to start with a simple, clean Justfile containing only the essential steps. I don’t want to maintain one cluttered with commands I never use.
@Xuanwo i've dropped some unnecessary changes (removed "RUF", # ruff-specific rules) from this PR in addition to your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
Which issue does this PR close?
Parts from #6622
Rationale for this change
Partially Closes #6253
What changes are included in this PR?
Are there any user-facing changes?
No, just better dev experience and code formatting.
No breaking changes are introduced.