-
Notifications
You must be signed in to change notification settings - Fork 730
feat(bindings/python)!: Generate stubs for Operator overloads and Scheme #6729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1b69f2f
add services module with PyScheme
chitralverma b8207af
ensure python 3.10 compatibility file.pyi
chitralverma 769a4e2
Add new service base
chitralverma 7dae5df
add config to docstrings
chitralverma 3ea5ed7
Merge branch 'main' into gen-services
chitralverma 968e491
fix
chitralverma 8f8010c
Add overloads to operators
chitralverma cf2d114
remove and replace files
chitralverma ababffe
overloads to use pyscheme directly
chitralverma 613c3a0
overloads to use pyscheme directly
chitralverma 3d736a6
Add Scheme to overloads
chitralverma fd97c21
Add returns section to overloads
chitralverma 2259881
update doc style
chitralverma 4226720
Merge branch 'main' into gen-services
chitralverma 7f66a28
Merge branch 'main' into gen-services
chitralverma a9c2ef2
Merge branch 'main' into gen-services
chitralverma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,8 @@ import collections.abc | |
| import types | ||
| import typing | ||
|
|
||
| import typing_extensions | ||
|
|
||
| @typing.final | ||
| class AsyncFile: | ||
| r""" | ||
|
|
@@ -111,7 +113,7 @@ class AsyncFile: | |
| ----- | ||
| A closed file cannot be used for further I/O operations. | ||
| """ | ||
| def __aenter__(self) -> typing.Self: ... | ||
| def __aenter__(self) -> typing_extensions.Self: ... | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| def __aexit__( | ||
| self, | ||
| exc_type: type[builtins.BaseException] | None, | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overloads and Scheme generates as part of the
stub-genprocessThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This made me think that can we move
stub_gentoodevinstead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually these are 2 separate processes that cannot be merged into the binding or in odev from what i understood.