chore: remove unused dependencies from core/examples/basic#6730
Closed
cfanbo wants to merge 2 commits intoapache:mainfrom
Closed
chore: remove unused dependencies from core/examples/basic#6730cfanbo wants to merge 2 commits intoapache:mainfrom
cfanbo wants to merge 2 commits intoapache:mainfrom
Conversation
dosubot
bot
added
size:S
Xuanwo
reviewed
Oct 23, 2025
|
|
||
| [dependencies] | ||
| futures = "0.3" | ||
| # futures = "0.3" |
Member
There was a problem hiding this comment.
Please just remove it if we don't need it.
|
|
||
| async fn example(op: Operator) -> Result<()> { | ||
| // Write data to S3. | ||
| // Write data to fs. |
Member
There was a problem hiding this comment.
This comment is not quite true since the storage could be any storage configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove unused dependencies from core/examples/basic and update coments