Skip to content

feat(bindings/python): Enable ftp/hdfs_native/sftp for python #6745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 4 commits into from
Oct 28, 2025
Merged

feat(bindings/python): Enable ftp/hdfs_native/sftp for python #6745

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
93abc06
re-enable some services
chitralverma Oct 28, 2025
26b980f
stable sort configs in services
chitralverma Oct 28, 2025
3fb2c86
remove unnecessary 11 services
chitralverma Oct 28, 2025
b85b550
Merge branch 'main' into enable-py-services
chitralverma Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
148 changes: 84 additions & 64 deletions bindings/python/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,106 +49,126 @@ default = [
# When enable or disable some features,
# Also, you need to update the `enabled_service` function in dev/src/generate/python.rs to match it.
services-all = [
"default",
"services-aliyun-drive",
"services-azfile",
"services-cacache",
"services-dashmap",
"services-dropbox",
# FIXME this service need protoc
# "services-etcd",
# FIXME this requires a preinstalled fdb library
# "services-foundationdb",
# "services-ftp",
"services-gdrive",
# FIXME how to support HDFS services in bindings?
# "services-hdfs",
# "services-hdfs-native",
"services-huggingface",
"services-ipfs",
"services-memcached",
"services-mini-moka",
"services-moka",
"services-onedrive",
"services-persy",
"services-postgresql",
"services-mysql",
"services-redb",
"services-redis",
# FIXME how to support rocksdb services in bindings?
# "services-rocksdb",
"services-sled",
"services-swift",
# FIXME this service need protoc
# "services-tikv",
"services-vercel-artifacts",
"services-mongodb",
"services-gridfs",
"services-sqlite",
"services-alluxio",
"services-b2",
"services-seafile",
"services-upyun",
"services-koofr",
"services-yandex-disk",
'default',
'services-aliyun-drive',
Comment on lines +52 to +53
Copy link
Copy Markdown
Contributor Author

@chitralverma chitralverma Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorted and cleaned this area up. moved comments in 1 place below.

re enabled the listed services

'services-alluxio',
'services-azfile',
'services-b2',
'services-cacache',
'services-cloudflare-kv',
'services-compfs',
'services-d1',
'services-dashmap',
'services-dbfs',
'services-dropbox',
'services-ftp',
'services-gdrive',
'services-github',
'services-gridfs',
'services-hdfs-native',
'services-huggingface',
'services-ipfs',
'services-koofr',
'services-lakefs',
'services-memcached',
'services-mini-moka',
'services-moka',
'services-mongodb',
'services-monoiofs',
'services-mysql',
'services-onedrive',
'services-opfs',
'services-pcloud',
'services-persy',
'services-postgresql',
'services-redb',
'services-redis',
'services-seafile',
'services-sftp',
'services-sled',
'services-sqlite',
'services-surrealdb',
'services-swift',
'services-upyun',
'services-vercel-artifacts',
'services-vercel-blob',
'services-yandex-disk',
]

# Default services provided by opendal.
# List of feature-flags for all services provided by opendal.
services-aliyun-drive = ["opendal/services-aliyun-drive"]
services-alluxio = ["opendal/services-alluxio"]
services-azblob = ["opendal/services-azblob"]
services-azdls = ["opendal/services-azdls"]
services-cos = ["opendal/services-cos"]
services-fs = ["opendal/services-fs"]
services-gcs = ["opendal/services-gcs"]
services-ghac = ["opendal/services-ghac"]
services-http = ["opendal/services-http"]
services-ipmfs = ["opendal/services-ipmfs"]
services-memory = ["opendal/services-memory"]
services-obs = ["opendal/services-obs"]
services-oss = ["opendal/services-oss"]
services-s3 = ["opendal/services-s3"]
services-webdav = ["opendal/services-webdav"]
services-webhdfs = ["opendal/services-webhdfs"]

# Optional services provided by opendal.
services-alluxio = ["opendal/services-alluxio"]
services-azfile = ["opendal/services-azfile"]
services-b2 = ["opendal/services-b2"]
services-cacache = ["opendal/services-cacache"]
Copy link
Copy Markdown
Contributor Author

@chitralverma chitralverma Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only sorted

services-cloudflare-kv = ["opendal/services-cloudflare-kv"]
services-compfs = ["opendal/services-compfs"]
services-cos = ["opendal/services-cos"]
services-d1 = ["opendal/services-d1"]
services-dashmap = ["opendal/services-dashmap"]
services-dbfs = ["opendal/services-dbfs"]
services-dropbox = ["opendal/services-dropbox"]
services-etcd = ["opendal/services-etcd"]
services-foundationdb = ["opendal/services-foundationdb"]
services-etcd = [
"opendal/services-etcd",
] # FIXME EXCLUDED: this service needs protoc
services-foundationdb = [
"opendal/services-foundationdb",
] # FIXME EXCLUDED: this service needs preinstalled fdb library
services-fs = ["opendal/services-fs"]
services-ftp = ["opendal/services-ftp"]
services-gcs = ["opendal/services-gcs"]
services-gdrive = ["opendal/services-gdrive"]
services-ghac = ["opendal/services-ghac"]
services-github = ["opendal/services-github"]
services-gridfs = ["opendal/services-gridfs"]
services-hdfs = ["opendal/services-hdfs"]
services-hdfs = [
"opendal/services-hdfs",
] # FIXME EXCLUDED: how to support HDFS services in bindings?
services-hdfs-native = ["opendal/services-hdfs-native"]
services-http = ["opendal/services-http"]
services-huggingface = ["opendal/services-huggingface"]
services-ipfs = ["opendal/services-ipfs"]
services-ipmfs = ["opendal/services-ipmfs"]
services-koofr = ["opendal/services-koofr"]
services-lakefs = ["opendal/services-lakefs"]
services-memcached = ["opendal/services-memcached"]
services-memory = ["opendal/services-memory"]
services-mini-moka = ["opendal/services-mini-moka"]
services-moka = ["opendal/services-moka"]
services-mongodb = ["opendal/services-mongodb"]
services-monoiofs = ["opendal/services-monoiofs"]
services-mysql = ["opendal/services-mysql"]
services-obs = ["opendal/services-obs"]
services-onedrive = ["opendal/services-onedrive"]
services-opfs = ["opendal/services-opfs"]
services-oss = ["opendal/services-oss"]
services-pcloud = ["opendal/services-pcloud"]
services-persy = ["opendal/services-persy"]
services-postgresql = ["opendal/services-postgresql"]
services-redb = ["opendal/services-redb"]
services-redis = ["opendal/services-redis"]
services-rocksdb = ["opendal/services-rocksdb"]
services-redis = ["opendal/services-redis", "opendal/services-redis-native-tls"]
Copy link
Copy Markdown
Contributor Author

@chitralverma chitralverma Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

included services-redis-native-tls

services-rocksdb = [
"opendal/services-rocksdb",
] # FIXME EXCLUDED: how to support rocksdb services in bindings?
services-s3 = ["opendal/services-s3"]
services-seafile = ["opendal/services-seafile"]
services-sftp = ["opendal/services-sftp"]
services-sled = ["opendal/services-sled"]
services-sqlite = ["opendal/services-sqlite"]
services-surrealdb = ["opendal/services-surrealdb"]
services-swift = ["opendal/services-swift"]
services-tikv = ["opendal/services-tikv"]
services-tikv = [
"opendal/services-tikv",
] # FIXME EXCLUDED: this service needs protoc
services-upyun = ["opendal/services-upyun"]
services-vercel-artifacts = ["opendal/services-vercel-artifacts"]
services-vercel-blob = ["opendal/services-vercel-blob"]
services-webdav = ["opendal/services-webdav"]
services-webhdfs = ["opendal/services-webhdfs"]
services-yandex-disk = ["opendal/services-yandex-disk"]

# we build cp311-abi3 and cp310 wheels now, move this to pyo3 after we drop cp310
abi3 = ["pyo3/abi3-py311"]
Comment on lines 181 to 182
Copy link
Copy Markdown
Contributor Author

@chitralverma chitralverma Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not remove the comment over abi, but this needs to be carefully done or there will be a conflict with stubgen.


Expand Down
Loading
Loading