Merged
Conversation
dosubot
bot
added
size:S
PsiACE
approved these changes
Jan 28, 2026
tisonkun
approved these changes
Jan 28, 2026
tisonkun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7158.
Rationale for this change
assert_sizewas intended as a development-only guard, but hard-coded struct sizes can legitimately vary across toolchains/platforms. This makes downstream packaging (e.g. Fedora) fail without any impact on correctness or user-facing behavior.What changes are included in this PR?
tests::assert_sizefromopendal-corecrate root.types::error::tests::assert_size.Are there any user-facing changes?
No.
How was this tested?
cd core && cargo fmtcd core && cargo test --libcd core && cargo clippy --all-targets --all-features -- -D warningsAI Usage Statement
This PR was authored with assistance from OpenAI Codex CLI (GPT-5.2).