Skip to content

fix(services/fs): add content length and modified time to metadata#7188

Merged
Xuanwo merged 1 commit intoapache:mainfrom
mhambre:fix/fs-metadata
Feb 23, 2026
Merged

fix(services/fs): add content length and modified time to metadata#7188
Xuanwo merged 1 commit intoapache:mainfrom
mhambre:fix/fs-metadata

Conversation

@mhambre
Copy link
Contributor

@mhambre mhambre commented Feb 11, 2026

Which issue does this PR close?

Closes #7187.

Rationale for this change

Explained in issue.

What changes are included in this PR?

Metadata is no longer defaulted and required data is saturated by the tokio::fs DirEntry's metadata.

Are there any user-facing changes?

N/A

AI Usage Statement

N/A

@mhambre mhambre requested a review from Xuanwo as a code owner February 11, 2026 03:27
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels Feb 11, 2026
@mhambre mhambre changed the title fix(serivadd content length and modified time to metadata fix(services/fs): add content length and modified time to metadata Feb 11, 2026
@jeevaprakashdr
Copy link

@matthambrecht I am new to the code base. I see this fix is simple. I am wondering if there is any way I can verify the changes.

@mhambre
Copy link
Contributor Author

mhambre commented Feb 18, 2026

@matthambrecht I am new to the code base. I see this fix is simple. I am wondering if there is any way I can verify the changes.

If you go back to the original issue I posted a simple code snippet to verify that the changes work

@jeevaprakashdr
Copy link

@matthambrecht I am new to the code base. I see this fix is simple. I am wondering if there is any way I can verify the changes.

If you go back to the original issue I posted a simple code snippet to verify that the changes work

Got the following from the code snipped mentioned in the issue.

Metadata {
    mode: DIR,
    is_current: None,
    is_deleted: false,
    cache_control: None,
    content_disposition: None,
    content_length: Some(
        128,
    ),
    content_md5: None,
    content_range: None,
    content_type: None,
    content_encoding: None,
    etag: None,
    last_modified: Some(
        Timestamp(
            2026-02-18T13:57:31.558337789Z,
        ),
    ),
    version: None,
    user_metadata: None,
}

For a empty directory content_length set to Some(128) I am unsure if this needs explicitly state in KB or MB

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 23, 2026
@Xuanwo Xuanwo merged commit c0802f1 into apache:main Feb 23, 2026
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Missing file size and access times for services-fs lister

3 participants