feat(services/swift): add conditional request headers for stat and read#7208
Merged
Xuanwo merged 1 commit intoapache:mainfrom Feb 23, 2026
Merged
feat(services/swift): add conditional request headers for stat and read#7208Xuanwo merged 1 commit intoapache:mainfrom
Xuanwo merged 1 commit intoapache:mainfrom
Conversation
Add If-Match, If-None-Match, If-Modified-Since, If-Unmodified-Since support for stat and read operations. Map HTTP 304 Not Modified to ConditionNotMatch error kind. Note: Swift does not support If-Match on PUT and only supports If-None-Match: * (not specific etag values) on PUT, so write conditional capabilities are not declared.
Xuanwo
approved these changes
Feb 23, 2026
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConditionNotMatcherror kindIf-None-Match: *on PUT, not specific etag valuesTest plan
test_stat_with_if_match,test_stat_with_if_none_match,test_stat_with_if_modified_since,test_stat_with_if_unmodified_since,test_read_with_if_match,test_read_with_if_none_match,test_read_with_if_modified_since,test_read_with_if_unmodified_sincenow execute instead of being silently skipped