fix(services/seafile): avoid defaulting list size to zero#7221
Merged
Conversation
koushiro
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #7062.
Rationale for this change
seafilelister currently maps missingsizein list response to0.This mixes "size is unknown in list response" with "real zero-byte file", which is semantically incorrect.
What changes are included in this PR?
core/services/seafile/src/lister.rs:unwrap_or(0)when setting filecontent_length.content_lengthonly wheninfo.sizeexists.This preserves correct zero-byte semantics while allowing core completion logic to fill missing sizes when needed.
Validation:
cargo fmtcargo check --features services-seafile,testscargo test -p opendal-service-seafileAre there any user-facing changes?
Yes.
For
seafile, list entries no longer reportcontent_length = 0when list response omitssize.AI Usage Statement
This PR was developed with Codex (GPT-5) assistance.