Skip to content

chore(doc): update clippy in core/CONTRIBUTING.md to align ci#7223

Closed
Svecco wants to merge 1 commit intoapache:mainfrom
Svecco:nan-document-xse
Closed

chore(doc): update clippy in core/CONTRIBUTING.md to align ci#7223
Svecco wants to merge 1 commit intoapache:mainfrom
Svecco:nan-document-xse

Conversation

@Svecco
Copy link

@Svecco Svecco commented Feb 24, 2026

Which issue does this PR close?

Close N/A

Originally in ./.github/workflows/ci_core.yml:78::

- name: Cargo clippy
  working-directory: core
  run: cargo clippy --workspace --all-targets --all-features -- -D warnings

But in ./core/CONTRIBUTING.md:7::

- `cargo clippy` to catch common mistakes and improve code.

cc @Xuanwo

Other columns: As Title/None.

@Svecco Svecco requested a review from Xuanwo as a code owner February 24, 2026 03:37
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell labels Feb 24, 2026
@Xuanwo
Copy link
Member

Xuanwo commented Feb 24, 2026

Hi, it's somewhat expected, as it can be quite challenging for contributors to get --all-features working.

@Svecco
Copy link
Author

Svecco commented Feb 24, 2026

Hi, it's somewhat expected, as it can be quite challenging for contributors to get --all-features working.

Okay, got it👌

@Svecco Svecco closed this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants