feat(core): enable presign delete#7386
Open
anandubey wants to merge 1 commit intoapache:mainfrom
Open
Conversation
dosubot
Bot
added
size:S
1 task
dentiny
reviewed
Apr 21, 2026
| } | ||
|
|
||
| pub async fn s3_delete_object(&self, path: &str, args: &OpDelete) -> Result<Response<Buffer>> { | ||
| pub async fn s3_delete_object_request( |
Contributor
There was a problem hiding this comment.
Suggested change
| pub async fn s3_delete_object_request( | |
| pub fn s3_delete_object_request( |
dentiny
reviewed
Apr 21, 2026
|
|
||
| pub async fn s3_delete_object(&self, path: &str, args: &OpDelete) -> Result<Response<Buffer>> { | ||
| pub async fn s3_delete_object_request( | ||
| &self, |
Contributor
There was a problem hiding this comment.
The easiest impl is to mimic what we do for head_object
- A function to get request:
pub fn get_delete_request() - A function to async delete:
pub async fn delete()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
The presign delete feature was implemented for feature request - #5427 by the PR - #5647, this PR is just enabling this feature.
Rationale for this change
Enable Presign delete feature
Are there any user-facing changes?
Yes, we used to generate PUT and DELETE presign URLs by the custom logic written by us, and we have recently moved to use opendal for this feature, but while testing we found although the feature is implemented, it was not enabled.