fix(services/onedrive): align service semantics#7393
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A (no existing issue; review-driven OneDrive cleanup)
Rationale for this change
The OneDrive backend had a few mismatches between Microsoft Graph behavior and OpenDAL's expected primitives. Some unsupported options were silently ignored,
create_dirdid not ensure missing ancestors, and version listing mixed current entries with historical versions.What changes are included in this PR?
200 OKas a successful completioncreate_dirrecursively ensure missing parent directorieslist_with_versionsstatUnsupportedfor operations and options that OneDrive cannot reliably support (read/stat/deletewith version, conditional write options, andcopywithif_not_exists)Are there any user-facing changes?
Yes. The OneDrive service now fails fast for unsupported options instead of silently ignoring them,
create_dirbehaves recursively, and version listing reports the current item separately from historical versions.AI Usage Statement
This PR was prepared with OpenAI Codex assistance for implementation and review.