fix(services/dropbox): preserve list semantics#7399
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A. This fix came out of a service review pass and I couldn't find a dedicated Dropbox issue for it.
Rationale for this change
Dropbox listing was building entries from
entry.name, which only contains the basename. That dropped operator-relative parent paths for nested entries and made exact-directory list requests behave too much like raw Dropbox prefix queries.What changes are included in this PR?
listso exact directory paths can be distinguished from file or prefix-style queriespath_displayrelative to the operator root instead of from the basename alonestat,list, andwritesoetag,version, and modified time stay consistentAre there any user-facing changes?
Users of the Dropbox service should now get correct relative paths from
list, especially for nested recursive listings and exact-directory queries.AI Usage Statement
Built with Codex (GPT-5).