Skip to content

fix(services/dropbox): preserve list semantics#7399

Open
suyanhanx wants to merge 2 commits intomainfrom
fix/dropbox-list-semantics
Open

fix(services/dropbox): preserve list semantics#7399
suyanhanx wants to merge 2 commits intomainfrom
fix/dropbox-list-semantics

Conversation

@suyanhanx
Copy link
Copy Markdown
Member

Which issue does this PR close?

N/A. This fix came out of a service review pass and I couldn't find a dedicated Dropbox issue for it.

Rationale for this change

Dropbox listing was building entries from entry.name, which only contains the basename. That dropped operator-relative parent paths for nested entries and made exact-directory list requests behave too much like raw Dropbox prefix queries.

What changes are included in this PR?

  • add a lightweight metadata check before Dropbox list so exact directory paths can be distinguished from file or prefix-style queries
  • build list entries from Dropbox path_display relative to the operator root instead of from the basename alone
  • emit the queried directory itself on the first list page to match OpenDAL list semantics
  • share Dropbox metadata parsing across stat, list, and write so etag, version, and modified time stay consistent
  • add unit tests for nested path preservation and directory normalization

Are there any user-facing changes?

Users of the Dropbox service should now get correct relative paths from list, especially for nested recursive listings and exact-directory queries.

AI Usage Statement

Built with Codex (GPT-5).

@suyanhanx suyanhanx marked this pull request as ready for review April 17, 2026 09:14
@suyanhanx suyanhanx requested a review from Xuanwo as a code owner April 17, 2026 09:14
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant