feat(metrics): add service operation to metrics label#7407
Open
dentiny wants to merge 1 commit intoapache:mainfrom
Open
feat(metrics): add service operation to metrics label#7407dentiny wants to merge 1 commit intoapache:mainfrom
dentiny wants to merge 1 commit intoapache:mainfrom
Conversation
cea9e7c to
ff2ff3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7310
Rationale for this change
In production when using opendal, one big pain point is I don't have metrics aggregated by S3 HTTP request type.
In detail, multipart upload contains multiple types of requests: initiation, upload part, and completion; each type of request correspond to different server handling and displays different success rate and latency; current client side metrics doesn't provide us enough insight.
This PR adds certain label for HTTP request metrics.
What changes are included in this PR?
In the attached issue, I follow @Xuanwo's proposal to add an extension, similar to what do we do for
operationlabel.A few changes:
A few considerations
Are there any user-facing changes?
No
AI Usage Statement
I used opus 4.6 to make most of the code change, and I'm responsible for code review/quality.