fix(services/sftp): preserve timeout error boundaries#7424
Open
fix(services/sftp): preserve timeout error boundaries#7424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None. Related to #7391.
Rationale for this change
The SFTP backend currently applies a generic timeout around pooled connection acquisition. In practice that can flatten several different failure stages into the same
connection request: timeouterror, which makes debugging much harder for callers and downstream users.This change keeps timeout protection, but moves it to the stage where it belongs.
What changes are included in this PR?
connect_timeoutfor the SSH connect stage and wire it toopenssh::SessionBuilder::connect_timeout(...)acquire_timeoutfor waiting on a saturated pooled SFTP connectionfailed to establish ssh connectionAre there any user-facing changes?
Yes.
SFTP users can now configure
connect_timeoutandacquire_timeoutseparately, and connection-stage failures should preserve the underlying SSH/SFTP error more often instead of being flattened into the same generic timeout.AI Usage Statement
Built with Codex (GPT-5).