Skip to content

HDDS-5045. Add rclone package for robot test #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2024
Merged

HDDS-5045. Add rclone package for robot test #37

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0698816
HDDS-5045. Add rclone package for robot test
ptlrs Dec 12, 2024
4ca791d
HDDS-5045. Use rpm packages to install rclone
ptlrs Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ RUN sudo python3 -m pip install --upgrade pip

COPY --from=go /go/bin/csc /usr/bin/csc

RUN dnf install -y unzip \
&& curl https://rclone.org/install.sh | sudo bash \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather re-implement download and extraction, instead of relying on a remote script that needs to be run as root.

Checksums are also available, see https://rclone.org/release_signing/

Copy link
Contributor Author

@ptlrs ptlrs Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am now using the latest rpm packages available from https://downloads.rclone.org/?sort=time&order=desc.
This helps to test with newer rclone packages as they are released.

Is this approach ok or is the preferred approach still to pin the package version and verify the checksums before using them? I can update the changes to use this approach if it is preferred.

&& dnf remove -y unzip \
&& dnf clean all

#For executing inline smoketest
RUN set -eux ; \
pip3 install awscli robotframework==6.1.1 boto3 ; \
Expand Down