HDDS-15249. SCM Pipeline Support Create And Get With StorageTier#10815
Open
devmadhuu wants to merge 7 commits into
Open
HDDS-15249. SCM Pipeline Support Create And Get With StorageTier#10815devmadhuu wants to merge 7 commits into
devmadhuu wants to merge 7 commits into
Conversation
Contributor
Author
|
@xichen01 Kindly review as discussed here. After merge of this in upstream feature branch, will raise for your 11th and 12th in your tar. Changes will be adapted to current https://github.com/apache/ozone/tree/HDDS-11233 feature branch. |
xichen01
reviewed
Jul 21, 2026
xichen01
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your patch, left a comments, and I think some tests should be adapted.
Contributor
There was a problem hiding this comment.
We should pass the storageTier too
Contributor
Author
There was a problem hiding this comment.
Done. Please review.
…default.storageTier to ozone-default.xml Signed-off-by: Devesh Singh <devesh_76@hotmail.com>
…ode setup Signed-off-by: Devesh Singh <devesh_76@hotmail.com>
devmadhuu
marked this pull request as ready for review
July 22, 2026 15:09
Contributor
|
@amaliujia @greenwich @chungen0126 @ivandika3 @peterxcli Please help to review |
Contributor
|
overall LGTM +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Thread a
StorageTierfrom the SCM block-allocation RPC down toPipelineFactory.create, so callers can request a pipeline (and, via #10810 , a container) on a specific storage tier. Removes the// TODO StoragePolicy replace this StorageTier with the passed StorageTierhardcode inPipelineFactorythat forced every pipeline creation onto DISK.Please describe your PR in detail:
Depends on #10810 (which adds a persisted
StorageTierfield toContainerInfo)Now with this PR:
AllocateScmBlock.RatisPipelineProvider/ECPipelineProvider, already tier-capable from HDDS-15250).What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15249
How was this patch tested?
Updated and extended tests in
TestBlockManager,TestSCMBlockProtocolServer