Skip to content

HDDS-15249. SCM Pipeline Support Create And Get With StorageTier#10815

Open
devmadhuu wants to merge 7 commits into
apache:HDDS-11233from
devmadhuu:HDDS-15249
Open

HDDS-15249. SCM Pipeline Support Create And Get With StorageTier#10815
devmadhuu wants to merge 7 commits into
apache:HDDS-11233from
devmadhuu:HDDS-15249

Conversation

@devmadhuu

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Thread a StorageTier from the SCM block-allocation RPC down to PipelineFactory.create, so callers can request a pipeline (and, via #10810 , a container) on a specific storage tier. Removes the // TODO StoragePolicy replace this StorageTier with the passed StorageTier hardcode in PipelineFactory that forced every pipeline creation onto DISK.

Please describe your PR in detail:

  1. Thread StorageTier through the block-allocation RPC and BlockManager
  2. Wire StorageTier into PipelineManager and PipelineFactory

Depends on #10810 (which adds a persisted StorageTier field to ContainerInfo)

Now with this PR:

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-15249

How was this patch tested?

Updated and extended tests in TestBlockManager, TestSCMBlockProtocolServer

@devmadhuu

devmadhuu commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

@xichen01 Kindly review as discussed here. After merge of this in upstream feature branch, will raise for your 11th and 12th in your tar. Changes will be adapted to current https://github.com/apache/ozone/tree/HDDS-11233 feature branch.

@xichen01 xichen01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patch, left a comments, and I think some tests should be adapted.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should pass the storageTier too

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please review.

@devmadhuu
devmadhuu requested a review from xichen01 July 22, 2026 11:48
@devmadhuu
devmadhuu marked this pull request as ready for review July 22, 2026 15:09
@xichen01

Copy link
Copy Markdown
Contributor

@amaliujia @greenwich @chungen0126 @ivandika3 @peterxcli Please help to review

@xichen01

Copy link
Copy Markdown
Contributor

overall LGTM +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants