HDDS-16312. SCM needs to choose apparent version for reconcile and reconstruct container commands - #11148
Open
errose28 wants to merge 4 commits into
Open
Conversation
(cherry picked from commit 3ec46b9b4cbac86002f9021217328baa6c3c4eba)
github-actions
Bot
added
the
zdu
dombizita
reviewed
Aug 31, 2026
| for (ReconstructECContainersCommand.DatanodeDetailsAndReplicaIndex source : command.getSources()) { | ||
| involved.add(getDatanodeInfo(source.getDnDetails())); | ||
| } | ||
| for (ReconstructECContainersCommand.DatanodeDetailsAndReplicaIndex target : command.getSources()) { |
Contributor
There was a problem hiding this comment.
The second loop shouldn't be the target nodes?
Suggested change
| for (ReconstructECContainersCommand.DatanodeDetailsAndReplicaIndex target : command.getSources()) { | |
| for (ReconstructECContainersCommand.DatanodeDetailsAndReplicaIndex target : command.getTargetDatanodes()) { |
Maybe worth to add a test case that covers this.
Contributor
Author
There was a problem hiding this comment.
Good catch, fixed in the last commit. The unit tests were only testing that the lowest version was used when it was a source. I split the EC and replication tests to test the source and target being the lowest separately. Reconciliation sends the same command to all nodes so there is no source/target distinction to test there.
errose28
marked this pull request as ready for review
September 1, 2026 13:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SCM is sending the lowest common apparent version to datanodes on the replication path. It must do the same thing for EC reconstruction and reconciliation so datanodes can execute the commands despite being in different versions. Since there are no incompatible changes on these paths yet, the version will be sent to datanodes but currently nothing reads them.
What is the link to the Apache JIRA
HDDS-16312
How was this patch tested?
Unit tests added