HDDS-15789. OM DB size should be reduced after compaction - #11173
Open
sravani-revuri wants to merge 2 commits into
Open
HDDS-15789. OM DB size should be reduced after compaction#11173sravani-revuri wants to merge 2 commits into
sravani-revuri wants to merge 2 commits into
Conversation
sravani-revuri
marked this pull request as ready for review
September 1, 2026 06:02
sarvekshayr
reviewed
Sep 1, 2026
sarvekshayr
left a comment
Contributor
There was a problem hiding this comment.
Thanks @sravani-revuri for working on this.
Question on timeouts: Were 300s (wait_for_bucket_deletion_complete) and 180s (wait_for_om_db_size_stable) chosen from observed wait times on CI?
Did you try shorter values (e.g. 240s / 120s) to see if the test becomes flaky again?
| [[ "${n:-1}" -eq 0 ]] || continue 2 | ||
| done | ||
| return 0 | ||
| sleep 3 |
Contributor
There was a problem hiding this comment.
sleep 3 is unreachable because it comes after return 0. The retry loop currently has no delay between polling attempts. Let's either move the sleep into the retry check or drop it if no delay is required as the test is passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Even after HDDS-14622, OM DB compaction test still encounters intermittent failure:
Deletion is an asynchronous process and the old test ran the compaction as soon as deletion started . There could be a situation where deletion is not yet completed and compaction is run. In this case new sst files are written which causes a higher number even after compaction is run , causing the test to fail intermittently.
The test now waits for deletion to complete and then runs compaction.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15789
How was this patch tested?
https://github.com/sravani-revuri/ozone/actions/runs/33398347599
sample output: