HDDS-16338. Fix no-op table size assertions in TestHSync - #11183
Open
shuan1026 wants to merge 2 commits into
Open
HDDS-16338. Fix no-op table size assertions in TestHSync#11183shuan1026 wants to merge 2 commits into
shuan1026 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TestHSynchad four no-op AssertJ calls of the formassertThat(n == collection.size()).assertThat(boolean)only builds anAbstractBooleanAssert, so those size checks never failed.They live in two tests:
testHSyncOpenKeyCommitAfterExpiry: after expire,OpenKeyCleanupServiceshould commit the hsynced open key and delete the non-hsync one. The size checks are about this test'skey1/key2, not the whole tables.testHSyncOpenKeyDeletionWhileDeleteDirectory: after hsync, openFileTable should have that one open key before the directory is deleted.This class shares one static bucket and
getOpenKeyInfo/getKeyInfoscan the entire layout. Turning the first test's checks into globalassertEqualsfailed CI (expected: <1> but was: <4>on fileTable; round 1) because other tests leave committed keys behind. That is shared test state, not an hsync/cleanup product bug.This PR:
assertEquals, matching the rest of the filefilterByKeyName(..., key1, key2)What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16338
How was this patch tested?
assertEqualsonly): failedTestHSync.testHSyncOpenKeyCommitAfterExpiry: https://github.com/shuan1026/ozone/actions/runs/33292933066/job/99208880146filterByKeyName): full fork CI: https://github.com/shuan1026/ozone/actions/runs/33299986156