HDDS-16371. [STS] Better messaging for invalid endpoint path and prevent non-canonical token use - #11186
Open
fmorg-git wants to merge 2 commits into
Open
HDDS-16371. [STS] Better messaging for invalid endpoint path and prevent non-canonical token use#11186fmorg-git wants to merge 2 commits into
fmorg-git wants to merge 2 commits into
Conversation
ChenSammi
reviewed
Sep 2, 2026
| try { | ||
| token.decodeFromUrlString(encodedToken); | ||
| final String canonical = token.encodeToUrlString(); | ||
| if (!canonical.equals(encodedToken)) { |
Contributor
There was a problem hiding this comment.
Overall looks good. Is heading and trailing blank space allowed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe your PR in detail:
/invalidPathat the end instead of the root path), then the aws client returns an opaque "Unknown" error. This ticket updates to give a more user-friendly message.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16371
How was this patch tested?
unit and smoke tests