Skip to content

chore(deps):update rust version be 1.86.0 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

chore(deps):update rust version be 1.86.0 #84

merged 1 commit into from
Apr 22, 2025

Conversation

camilesing
Copy link
Contributor

for #81

@camilesing camilesing changed the title update rust version be 1.86.0 chore(deps):update rust version be 1.86.0 Apr 22, 2025
Xuanwo
Xuanwo approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change. Looks good to me.

Ideally, we should establish an MSRV policy, but paimin-rust is still a long way from being usable. I’m fine with setting the MSRV to the latest stable version of Rust.

@Xuanwo
Copy link
Member

Xuanwo commented Apr 22, 2025

cc @Aitozi for another look.

Aitozi
Aitozi approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@Aitozi Aitozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Aitozi Aitozi merged commit 1f69c4a into apache:main Apr 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@Aitozi Aitozi Aitozi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camilesing @Xuanwo @Aitozi