[Python] Introduce incremental-between read by timestamp #6391
+1,008
−495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Oct 13, 2025
|
Also you can add with_shard to doc too. |
|
ok. |
ok. |
|
get_ealiest_snapshot is the same as get_latest_snapshot: |
leaves12138
reviewed
Oct 15, 2025
| for snapshot_id in range(self.startingSnapshotId + 1, self.endingSnapshotId + 1): | ||
| snapshot = self.snapshot_manager.get_snapshot_by_id(snapshot_id) | ||
| if snapshot: | ||
| snapshots_in_range.append(snapshot) |
There was a problem hiding this comment.
If delta scan, we should skip APPEND && OVERWRITE snapshots
discivigour
force-pushed
the
incrementalScan
branch
from
f8dab74 to
b6ec35a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Read incremental changes between start timestamp (exclusive) and end timestamp, for example, 't1,t2' means changes between timestamp t1 and timestamp t2.
Tests
API and Format
Documentation