GH-3342: Throw typed exception for Parquet footer error #3343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently,
ParquetFileReaderthrowsRuntimeExceptions when footer parsing fails.This can be improved by throwing a
ParquetDecodingExceptioninstead, so footer corruption surfaces as a typed exception instead of a plainRuntimeException. This helps avoid matching on error message to catch errors occurred during footer parsing.What changes are included in this PR?
Throw a
ParquetDecodingExceptionwhen Parquet footer parsing fails instead of aRuntimeException. The error messages remain the same.Are these changes tested?
Existing tests.
ParquetDecodingExceptionextendsRuntimeExceptionso existing catch code should continue to work.Are there any user-facing changes?
No.
Closes #3342