Skip to content

Fix Subscribe QoS encode and UnsubAck decode. #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix Subscribe QoS encode and UnsubAck decode. #1152

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45a59c2
- Fix Subscribe QoS encoding: https://docs.oasis-open.org/mqtt/mqtt/v…
Sep 2, 2025
cfa6a16
Fix compilation
Sep 2, 2025
19e43fe
Fix compilation
Sep 2, 2025
58570e9
Fix mima warning and tests
Sep 2, 2025
a700fad
Changes after review by pfjanning
Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,7 @@ def pekkoConnectorProject(projectId: String,
},
mimaBinaryIssueFilters ++= Seq(
ProblemFilters.exclude[Problem]("*.impl.*"),
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.stream.connectors.mqtt.streaming.ControlPacketFlags.ReservedUnsubAck"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have a look in the repo? We tend to use files in src/mima-filters to add the excludes - a new file with each PR that breaks bin compat.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the repo, but couldn't find a file for mqtt-streaming folder. Should I create a new one?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjfanning I created the file.

// generated code
ProblemFilters.exclude[Problem]("com.google.*")),
Test / parallelExecution := false)
Expand Down
2 changes: 1 addition & 1 deletion mqtt-streaming/src/main/scala/org/apache/pekko/stream/connectors/mqtt/streaming/model.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,7 +977,7 @@ object MqttCodec {
: Vector[(Either[DecodeError, String], ControlPacketFlags)] =
if (remainingLen > 0) {
val packetLenAtTopicFilter = v.len
val topicFilter = (v.decodeString(), ControlPacketFlags(v.getByte & 0xFF))
val topicFilter = (v.decodeString(), ControlPacketFlags((v.getByte & 0xFF) << 1))
decodeTopicFilters(remainingLen - (packetLenAtTopicFilter - v.len), topicFilters :+ topicFilter)
} else {
topicFilters
Expand Down