Skip to content

missing asf header #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

missing asf header #675

merged 1 commit into from
May 9, 2025

Conversation

@pjfanning
Copy link
Member

@pjfanning pjfanning commented May 9, 2025

need Apache source header

@pjfanning
Copy link
Member Author

pjfanning commented May 9, 2025 •
edited
Loading

@raboof are these files in the right directory - should they be in 1.1.x.backwards.excludes instead of 1.2.x.backwards.excludes?
I get the impression that we sometimes say the dir is called after the release previous version and sometimes call it after the expected next release version.

This change is consistent with #647 - so if this is wrong, that is wrong too

@pjfanning pjfanning merged commit 670b3a7 into apache:main May 9, 2025
9 of 10 checks passed
@pjfanning pjfanning deleted the missing-asf-header branch May 9, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@He-Pin He-Pin He-Pin approved these changes

@mdedetrich mdedetrich Awaiting requested review from mdedetrich

@raboof raboof Awaiting requested review from raboof

@nvollmar nvollmar Awaiting requested review from nvollmar

@samueleresca samueleresca Awaiting requested review from samueleresca

@Roiocam Roiocam Awaiting requested review from Roiocam

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pjfanning @He-Pin