additional mailbox selector for typed props#1096
Conversation
|
@Roiocam can you put the typo fixes in a separate PR? We can backfit that change. |
...yped-tests/src/test/scala/org/apache/pekko/actor/typed/scaladsl/DispatcherSelectorSpec.scala
Outdated
Show resolved
Hide resolved
| parentProbe.ref) | ||
|
|
||
| val childProbe = createTestProbe[ActorRef[Ping]]() | ||
| grandParent ! SpawnProtocol.Spawn(PingPong(), "child", Props.empty.withDispatcherSameAsParent, childProbe.ref) |
There was a problem hiding this comment.
Fix children not spawn from the parent
Roiocam
force-pushed
the
additional-typed-props-mailbox-selector
branch
from
3b83298 to
8e3f603
Compare
Roiocam
force-pushed
the
additional-typed-props-mailbox-selector
branch
from
93fac01 to
b9b046d
Compare
Roiocam
force-pushed
the
additional-typed-props-mailbox-selector
branch
from
d1302b7 to
7cbc958
Compare
Roiocam
force-pushed
the
additional-typed-props-mailbox-selector
branch
from
7cbc958 to
9c1022f
Compare
actor-typed-tests/src/test/scala/docs/org/apache/pekko/typed/MailboxDocSpec.scala
Outdated
Show resolved
Hide resolved
| import org.scalatest.wordspec.AnyWordSpecLike | ||
|
|
||
| import org.apache.pekko | ||
| import pekko.actor.typed.DispatcherSelector |
There was a problem hiding this comment.
can you reorder the imports and put back the empty line above?
There was a problem hiding this comment.
Sorry about the delay, could you review this again and contain this in release 1.1.0?
pjfanning
left a comment
pjfanning
left a comment
There was a problem hiding this comment.
lgtm - but it would be good if someone else reviews this too
pjfanning
requested review from
He-Pin,
jrudolph,
mdedetrich,
raboof and
samueleresca
|
@mdedetrich would you have time to review this? I'm hoping to get the RC for v1.1.0 together in the next few days. |
|
I will look at it tonight |
|
@kerr would you have time to review this? |
mdedetrich
left a comment
mdedetrich
left a comment
There was a problem hiding this comment.
lgtm although would really like a review from someone else. If all else fails we can use @ApiMayChange as a clutch.
|
I looked again and I think this is pretty safe. |
4 participants
Motivation
I have experience in migrating Classic to Typed. In the process, I found that Typed can't customize Mailbox through Props. We should match the same Classic method on Typed.
TODO list