chore: avoid the double evaluation of entityId in ClusterSharding

[Roiocam]

Found something we could optimized it.

[laglangyue]

Seems like duplicate code, can it be abstracted

[pjfanning]

blocking - needs discussion on the dev list because of the ongoing release discussion

[Roiocam]

Use the cacheable partial function, and then verify it works.

var calTime: Int = 0
def entityId(value: Any): String = {
  calTime = calTime + 1
  value match {
    case "wrong" => null
    case _ => String.valueOf(value)
  }
}

def extractEntityIdFromExtractor: PartialFunction[Any, Any] =
  new scala.runtime.AbstractPartialFunction[Any, (String, Any)] {
    var cache: String = _

    override def isDefinedAt(msg: Any): Boolean = {
      cache = entityId(msg)
      cache != null
    }

    override def apply(x: Any): (String, Any) = (cache, x)
  }

lazy val xx = extractEntityIdFromExtractor

lazy val yy: PartialFunction[Any, Any] = {
  case message if entityId(message) != null => (entityId(message), message)

}

assert(!xx.isDefinedAt("wrong"))
assert(!yy.isDefinedAt("wrong"))
calTime = 0
val health = "health"
println(xx.isDefinedAt(health))
println(xx(health))
println(s"caltime = $calTime")
println("=====")
calTime = 0
println(yy.isDefinedAt(health))
println(yy(health))
println(s"caltime = $calTime")

1.1.0-M1 vote passed

[pjfanning]

lgtm

[pjfanning]

@Roiocam is it ok to get this merged now?

[Roiocam]

@Roiocam is it ok to get this merged now?

I have no objections to this, but it would be better if there were reviews from others.

[nvollmar]

lgtm