chore: clean code in ClusterSharding#1305
Merged
Roiocam merged 2 commits intoapache:mainfrom May 19, 2024
Merged
Conversation
Roiocam
commented
Apr 30, 2024
| // using classic.systemActorOf to avoid the Future[ActorRef] | ||
| system.toClassic | ||
| .asInstanceOf[ExtendedActorSystem] | ||
| .systemActorOf( |
Member
Author
There was a problem hiding this comment.
The before code didn't return ActorRef with typed? looks like a bug too.
pjfanning
previously requested changes
May 2, 2024
Member
pjfanning
left a comment
There was a problem hiding this comment.
No merges should be happening at the moment. We have an open mail thread about doing a release. It is chaos if people keep merging changes. All changes - however small - should be discussed on the mail thread about the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make code cleaner, it is basically the same.
Before using
pekko/actor-typed/src/main/scala/org/apache/pekko/actor/typed/scaladsl/adapter/PropsAdapter.scala
Lines 31 to 36 in b5eb6ff
After
pekko/actor-typed/src/main/scala/org/apache/pekko/actor/typed/internal/adapter/ActorSystemAdapter.scala
Lines 125 to 133 in b5eb6ff