Avoid unnecessary shard updates while shutting down#1342
Merged
Conversation
Member
|
looks sensible to me - let's see what other reviewers say When we get a fix in, we might want to backport it to 1.0.x. I think we should make a 1.0.3 release in the next few weeks. |
Contributor
Author
|
Would be good to have that in 1.0.3 |
Roiocam
approved these changes
May 29, 2024
nvollmar
added a commit
that referenced
this pull request
Jun 4, 2024
* Avoid unnecessary shard updates while shutting down * Avoid re-creating the same message for each shard
nvollmar
added a commit
that referenced
this pull request
Jun 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1341