fix: only setFailed when actor not null#1399
Merged
Roiocam merged 2 commits intoapache:mainfrom Jul 18, 2024
Merged
Conversation
He-Pin
reviewed
Jul 18, 2024
pjfanning
approved these changes
Jul 18, 2024
Member
pjfanning
left a comment
pjfanning
left a comment
There was a problem hiding this comment.
lgtm
can you backport this to 1.0.x when you merge it?
Member
Author
|
tests passed in https://github.com/apache/pekko/actions/runs/9987454134 |
He-Pin
approved these changes
Jul 18, 2024
Member
Author
|
@sadekmunawar would your take a look? |
Member
Author
Thanks for the review @sadekmunawar |
Roiocam
added a commit
to Roiocam/pekko
that referenced
this pull request
Jul 18, 2024
* fix: only setFailed when actor not null * chore: use ne rather than !=
Roiocam
added a commit
to Roiocam/pekko
that referenced
this pull request
Jul 18, 2024
* fix: only setFailed when actor not null * chore: use ne rather than !=
pjfanning
pushed a commit
that referenced
this pull request
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continue #1385, we allow empty actorRef now.