Skip to content

feat: streamlined approach for Behaviors #1444#1445

Merged
pjfanning merged 5 commits intoapache:mainfrom
Roiocam:behaviors-streamlined-approach
Aug 28, 2024
Merged

feat: streamlined approach for Behaviors #1444#1445
pjfanning merged 5 commits intoapache:mainfrom
Roiocam:behaviors-streamlined-approach

Conversation

@Roiocam
Copy link
Member

@Roiocam Roiocam commented Aug 23, 2024

Resolves: #1444

@pjfanning pjfanning added this to the 1.1.0 milestone Aug 23, 2024
@pjfanning
Copy link
Member

@Roiocam Is this something that could be ready in the next few days? If not, can we delay it to the 1.1.1 release?

@Roiocam
Copy link
Member Author

Roiocam commented Aug 23, 2024

@Roiocam Is this something that could be ready in the next few days? If not, can we delay it to the 1.1.1 release?

It's not in that hurry to contain in release 1.1.0, but I'll try my best to delivery it.

@Roiocam Roiocam marked this pull request as ready for review August 23, 2024 19:20
Copy link
Member

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Roiocam if this is ready to merge, could I ask for one extra change? Could you add @since 1.1.0 to the scaladoc on the new methods?

@Roiocam
Copy link
Member Author

Roiocam commented Aug 27, 2024

@Roiocam if this is ready to merge, could I ask for one extra change?

It is ready!

Could you add @since 1.1.0 to the scaladoc on the new methods?

done. Thanks

Copy link
Member

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning
Copy link
Member

@Roiocam is it ok to merge this? I'm hoping to start the release process for v1.1.0.

@Roiocam
Copy link
Member Author

Roiocam commented Aug 28, 2024

@Roiocam is it ok to merge this? I'm hoping to start the release process for v1.1.0.

i am no objection to this. it's just syntax sugar.

@pjfanning pjfanning merged commit db8d20d into apache:main Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Streamlined approach for Behavior Factory

2 participants