Open
Conversation
Member
|
Another thing is with the current implementation, the virtual thread is never pooled, which means the ThreadLocalRandom will not leak the thread locals |
Member
Author
|
So far, it seems that the performance is lower if you do not use the ThreadLocalRandom. The speed is still good and I don't think we are in a hotspot area where the small perf loss here will make a big diff. I don't think anyone should use this option unless they have a good reason to worry about their virtual thread usage leading to an excessive amount of object instance creation (one ThreadLocalRandom instance per virtual thread). |
dba4e2c to
55f2f20
Compare
scalafmt some compile issues Update ReplicatedShardingTest.java stub of JEP 356 generator Update RandomNumberGenerator.scala java version check Update RandomNumberGenerator.scala add test Update RandomNumberGenerator.scala add test Update RandomNumberGeneratorJava21Spec.scala merge issue scalafmt
55f2f20 to
f9e37ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.