Move integration tests to polaris-server
#3261
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
reviewed
Dec 15, 2025
| implementation(enforcedPlatform(libs.quarkus.bom)) | ||
| implementation("io.quarkus:quarkus-container-image-docker") | ||
|
|
||
| testImplementation("io.quarkus:quarkus-junit5") |
Contributor
There was a problem hiding this comment.
Two questions / doubts here:
- Why modify the
testImplementationconfiguration here? I don't think it applies to integration tests. - Do we need to add
testImplementation(enforcedPlatform(libs.quarkus.bom))?
Contributor
Author
There was a problem hiding this comment.
oops, my mistake. Thx for catching it... will fix.
Contributor
Author
There was a problem hiding this comment.
I had to make a build config change and move a non-QuarkusIntegrationTest back to runtime/service... but I hope the end result is better now :)
dimas-b
force-pushed
the
move-service-its
branch
from
104e25c to
7b01d17
Compare
adutra
reviewed
Dec 16, 2025
Contributor
There was a problem hiding this comment.
Shouldn't we rename this test to something ending with Test? It is also oddly designed, the nested class seems unnecessary.
Contributor
There was a problem hiding this comment.
BTW: the nested test class is not being executed, it is lacking the @Nested annotation. All in all, I think this test class could be deleted.
`@QuarkusIntegrationTest` uses the regular server build with only non-test dependencies. Therefore, those tests naturally belong into the `server` module. This change is as a prerequisite for apache#3252 to allow the `polaris-runtime-service` module to avoid having Polaris extensions as runtime dependencies. Extensions will be runtime dependencies only in the `polaris-server` module.
dimas-b
force-pushed
the
move-service-its
branch
from
7b01d17 to
8331a24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@QuarkusIntegrationTestuses the regular server build with only non-test dependencies. Therefore, those tests naturally belong into theservermodule.This change is as a prerequisite for #3252 to allow the
polaris-runtime-servicemodule to avoid having Polaris extensions as runtime dependencies. Extensions will be runtime dependencies only in thepolaris-servermodule.Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)