Ensure release publish workflow can only run from last RC (#3290) #3295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a safety check in the 4th release workflow that publishes artifacts after a vote has passed for a given RC. When the workflow is run, it verifies that it is running on a
release/[major].[minor].xbranch and that the head of that branch corresponds to the last RC tag. That second condition ensures that no new commit has been added since the vote started for the last RC. It is necessary because part of publishing involves rebuilding Polaris Docker images, so the source code must be identical to the RC.Marking this PR as draft given that it has not been tested yet.