CLI: Improve client cleanup in Makefile#5160
Open
MonkeyCanCode wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existed
client-cleanupis not completed as it would still left couple temp dirs around and never clean up them if we want a "clean"client/pythondirectory that matches to what we have out of box. Here are the changes:client/python/distdir (this got created viamake client-buildclient/python/specandclient/python/.openapi-generatordirs (these got created viamake client-regenerateclient/python/.pytest_cachedir (this got created viamake client-integration-test)clien/python/**/__pycache__dirs (these got created viaclient-regenerate)*.pycas those are part of__pycache__since python3 and it will be cleanup along with item 5.VENV_DIRcleanup to match to the rest of the cleanup.Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)