[CI] Add clang-tidy check with clang-analyzer and performance checks

[BewareMyPower]

Fixes #200

Code is fixed mostly due to the following checks, especially for the performance-unnecessary-value-param because the existing code passes std::shared_ptr and std::function by value in many places, which harms the performance. The virtual call in the destructor like ProducerImpl::shutdown is also fixed.

Reference: https://clang.llvm.org/extra/clang-tidy/checks/list.html

Safety

• clang-analyzer-optin.cplusplus.VirtualCall
• clang-analyzer-cplusplus.Move

Performance

• clang-analyzer-optin.performance.Padding
• performance-enum-size
• performance-noexcept-move-constructor
• performance-unnecessary-value-param
• performance-faster-string-find
• performance-avoid-endl
• performance-move-const-arg
• performance-unnecessary-copy-initialization

Code Quality

• clang-analyzer-deadcode.DeadStore

[Copilot]

Pull Request Overview

This pull request adds enhanced clang-tidy checks—including clang-analyzer and performance checks—to improve code quality and runtime efficiency by addressing unnecessary value parameters and virtual calls.

• Updates function signatures to pass callbacks, strings, and shared pointers as const references to avoid extra copies.
• Explicitly sets enum underlying types to uint8_t for consistency and potential performance improvements.
• Adds CI workflow steps for linting and clang-tidy analysis.

Reviewed Changes

Copilot reviewed 123 out of 123 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
include/pulsar/ProducerConfiguration.h	Added include and updated enum declarations and parameter types.
include/pulsar/Producer.h	Revised asynchronous callback parameters and shared pointer constructor.
include/pulsar/Logger.h	Updated enum declaration with underlying type specifier.
include/pulsar/KeySharedPolicy.h	Updated enum declaration with underlying type specifier.
include/pulsar/InitialPosition.h	Updated enum declaration with underlying type specifier.
include/pulsar/FileLoggerFactory.h	Added missing include.
include/pulsar/EncryptionKeyInfo.h	Changed setKey signature and adjusted constructor parameter type.
include/pulsar/CryptoKeyReader.h	Updated file parameter signature to const reference.
include/pulsar/ConsumerType.h	Updated enum declaration with underlying type specifier.
include/pulsar/ConsumerConfiguration.h	Updated setter signature to use a const reference.
include/pulsar/Consumer.h	Revised several asynchronous callback parameters to use const references.
include/pulsar/ConsoleLoggerFactory.h	Added missing include.
include/pulsar/CompressionType.h	Updated enum declaration with underlying type specifier.
include/pulsar/ClientConfiguration.h	Updated enum declaration with underlying type specifier and includes.
include/pulsar/Client.h	Revised asynchronous API signatures to pass parameters by const reference.
include/pulsar/Authentication.h	Replaced an enum with a static constexpr for undefined_expiration.
build-support/run_clang_tidy.sh	Added a new script to run clang-tidy across the codebase.
CMakeLists.txt	Adjusted compiler options per updated guidelines.
.github/workflows/ci-pr-validation.yaml	Introduced new lint jobs and updated build configurations.
.clang-tidy	Added configuration for clang-tidy checks.

Comments suppressed due to low confidence (3)

include/pulsar/Producer.h:164

• Changing the Producer constructor to take a shared pointer by const reference instead of by value may affect reference counting and lifetime management; please ensure that a copy is made internally if needed to maintain expected ownership semantics.

explicit Producer(const ProducerImplBasePtr&);

include/pulsar/Consumer.h:86

• Converting asynchronous callback parameters to const references improves performance, but please confirm that their lifetimes are properly managed (for example, by copying them if they are stored for later invocation) to avoid potential dangling references.

void unsubscribeAsync(const ResultCallback& callback);

include/pulsar/Client.h:104

• Ensure that passing the callback as a const reference for asynchronous operations does not introduce lifetime issues; if the callback is stored beyond the function call, an internal copy should be made.

void createProducerAsync(const std::string& topic, const CreateProducerCallback& callback);

[RobertIndie]

The producer in the map producers is a weak ptr. Calling the clear here doesn't guarantee the desturctor will be called. So the shutdown may not be called here. However, I think we should make sure all the producers/consumers should be shutdown after the client shutdown.

[BewareMyPower]

Good find! It makes sense. Let me think of a better solution.

[RobertIndie]

Should we delete the files.txt here?