Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Update deliverAfter and deliverAt api comment #1339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

geniusjoe
Copy link
Contributor

Contribution Checklist

Master Issue: apache/pulsar#23968

Motivation

Related Issue: apache/pulsar-site#507

We now support consuming delayed messages with shared and Key-shared type subscriptions, which has been corrected since pulsar 3.x doc in above pr.

But Golang code deliverAt and deliverAfter comment says we can only support Shared type subscription, so that maybe we need to fix them.

Modifications

Replace SubscriptionType=Shared comment with SubscriptionType=Shared or SubscriptionType=KeyShared in deliverAt and deliverAfter api.

Verifying this change

  • Make sure that the change passes the CI checks.
    This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant