Implement ReconsumeLater on regex consumer #1456
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently,
ReconsumeLaterandReconsumeLaterWithCustomPropertiesare unimplemented onregexConsumer. From what I can tell, these appear to just be missing methods rather than some fundamental limitation of the consumer implementation. Hopefully I'm correct there.Modifications
I've essentially copied over the
ReconsumeLaterWithCustomPropertiesimplementation frommultiTopicConsumer. I ran into the problem that the current code to add the RLQ topic to the consumer'sTopicsslice doesn't take into account subscriptions defined byTopicsPattern. To address this, I (perhaps naively) append the RLQ topic to the slice returned byregexConsumer.topics().Verifying this change
This change added tests and can be verified as follows:
ReconsumeLateron a regex-based consumer causes the message to be published to the RLQ.Does this pull request potentially affect one of the following parts:
Documentation