Skip to content

[fix][function]Let packagesManagement start before function work service #16502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liangyuanpeng
Copy link
Contributor

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

Master Issue: #

Motivation

Pulsar Function will run failed when pulsar standalone restart, the reason is function work service start before package management service.

Had enable package management and got the error of Package Management Service is not enabled in the broker.

lanrendeMacBook-Pro:~ lanren$ pulsarctl functions status --name win
{
  "numInstances": 1,
  "numRunning": 0,
  "instances": [
    {
      "instanceId": 0,
      "status": {
        "running": false,
        "error": "Package Management Service is not enabled in the broker.",
        "numRestarts": 0,
        "numReceived": 0,
        "numSuccessfullyProcessed": 0,
        "numUserExceptions": 0,
        "latestUserExceptions": null,
        "numSystemExceptions": 0,
        "latestSystemExceptions": null,
        "averageLatency": 0,
        "lastInvocationTime": 0,
        "workerId": "c-standalone-fw-localhost-8080"
      }
    }
  ]
}

Modifications

Let package management service start before function work service.

Verifying this change

  • Make sure that the change passes the CI checks.
  1. run pulsar standalone
  2. create function
  3. restart pulsar standalone
  4. check function status

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed

Bug Fix

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 10, 2022
@liangyuanpeng liangyuanpeng changed the title Let packagesManagement start before function work service [fix][standalone][function]Let packagesManagement start before function work service Jul 10, 2022
@liangyuanpeng liangyuanpeng changed the title [fix][standalone][function]Let packagesManagement start before function work service [fix][function]Let packagesManagement start before function work service Jul 10, 2022
Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please help add a unit test or integration test?

@liangyuanpeng
Copy link
Contributor Author

Absolutely, i will add some test.

@codelipenghui codelipenghui modified the milestones: 2.11.0, 2.12.0 Jul 26, 2022
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@congbobo184
Copy link
Contributor

@liangyuanpeng hi, I move this PR to release/2.9.5, if you have any questions, please ping me. thanks.

@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@poorbarcode poorbarcode added this to the 3.1.0 milestone Apr 10, 2023
@michaeljmarshall
Copy link
Member

As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/function doc-not-needed Your PR changes do not impact docs release/2.10.4 release/3.0.12 Stale type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.