Skip to content

Conversation

@gaecfov
Copy link

@gaecfov gaecfov commented May 31, 2023

Fixes #20427

Modifications

When subscribing, if the topic is already a retry topic, the corresponding retry topic will no longer have the -RETRY suffix added.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions
Copy link

@gaecfov Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels May 31, 2023
@tisonkun
Copy link
Member

tisonkun commented Jun 2, 2023

@poorbarcode Please check if this PR should be covered under #20445 or can go forward alone.

Although, please open a PR against master first and we may or may not pick it to released branch. This PR is against branch-3.0 so I'd close it now.

@tisonkun tisonkun closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants