-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[pip] PIP-373 Support to specify message listeners in TableView constructor #23167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@heesung-sn Please add the following content to your PR description and select a checkbox:
|
PIP-371 and PIP-372 already exist. |
pip/pip-369.md
Outdated
* If {@link TableViewBuilder#existingMessageListeners} are not specified, | ||
* these listeners are used for both | ||
* existing and tailing(future) messages in the topic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that it's a great idea to use this for both types. If someone wants the listener on both types, why not just register it for the other type of listener separately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will require setting the same listener for both, which I think is redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont have strong opinion here, but I thought that we want the client design for less code.
@heesung-sn please up the mailing list threads to the document. |
Please refer to this fork PR for an implementation example. heesung-sn#79