[improve][pip] PIP-377: Automatic retry for failed acknowledgements #23267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PIP
doc
lhotari
force-pushed
the
lh-pip-377-autoRetryAcknowledgement
branch
from
038e640 to
f2649a5
Compare
3 tasks
This was referenced Sep 7, 2024
|
Is there a precise step to reproduce the acknowledgment lost? |
@aloyszhang not yet, there's #22709 and #21958 where it seems that acks get lost. One possible way that acks could get lost is due to the issue described in #23200 where the number of ack holes exceeds the default limit of 10000. If the the consumer gets reconnected at this time (client connection breaks or due to load balancing event), acks would get lost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the pip-377.md file
Modifications
In the pip-377.md file
Documentation
docdoc-requireddoc-not-neededdoc-complete